Article ID: 50694
Article Last Modified on 12/12/2003
APPLIES TO
- Microsoft Visual C++ 1.0 Professional Edition
- Microsoft Visual C++ 1.5 Professional Edition
- Microsoft Visual C++ 2.0 Professional Edition
- Microsoft Visual C++ 4.0 Standard Edition
- Microsoft Visual C++ 5.0 Enterprise Edition
- Microsoft Visual C++ 6.0 Enterprise Edition
- Microsoft Visual C++ 5.0 Professional Edition
- Microsoft Visual C++ 6.0 Professional Edition
- Microsoft Visual C++ 6.0 Standard Edition
This article was previously published under Q50694
SUMMARY
Side effect operators (++, --, =, +=, -=, *=, /=, %=, &=, |=, ^=, <<=, and >>=) may cause unexpected results if they are used on the same variable or memory location more than once in the same expression. The order in which side effects occur within an expression is not specified.
Do NOT expect any specific order of evaluation to take place. The discretion is left to the compiler to determine how it implements the evaluation order. The evaluation order could be affected by machine architecture and code optimization. Although such code may work sometimes, it is not guaranteed to work, and is therefore unsafe.
NOTE: Kernighan and Ritchie do an excellent job explaining the ANSI C Standard for the evaluation order of expressions in Section 2.12 of "The C Programming Language - 2nd Edition" by Kernighan and Ritchie.
MORE INFORMATION
It is easy to accidentally write nonportable code with the C language. Below are some other common examples of statements that can cause side effects during run time:
printf("%d %d \n", ++n, power(2, n)); /* WRONG */
The above statement can produce different results with different compilers, depending on whether "n" is incremented before "power" is called. The correct code is as follows:
n++; /* CORRECT */
printf("%d %d \n", n, power(2, n));
Another common pitfall is the following:
a[i] = i++; /* WRONG */
The question is whether the subscript of "a" is the old value of "i" or the new value. The correct code is as follows:
a[i] = a[i+1]; /* CORRECT */
i++;
Another example is as follows:
int x[10], *p = x;
*p++ = *p++ = 0; /* WRONG */
The compiler is allowed to "p" twice at the end after doing the two assignments, if it so chooses. To ensure correct code generation, you must code as follows:
*p++ = 0; *p++ = 0; /* CORRECT */
In general, any object may have its stored value modified at most once in a single expression; in addition, the prior value shall be accessed only to determine the value to be stored. Therefore,
i = i + 1; /* OK */
is allowed because "i" is modified only once, and "i" is accessed only to determine what to store in "i", but
i = ++i + 1; /* UNDEFINED */
is undefined because "i" is modified more than once in the course of the evaluation of the expression. Instead, the following pair of statements is correct:
++i;
i = i + 1; /* OK */
The statement:
a[i] = i++; /* UNDEFINED */
is undefined, because, although "i" is only modified once, it is accessed both to determine the value to be stored in "i" by the ++ operator and as a subscript.
Keywords: kbinfo kblangc KB50694
