Microsoft KB Archive/190531

= FIX: Calling delete or free in ATL Causes Access Violation =

Article ID: 190531

Article Last Modified on 2/24/2004

-

APPLIES TO

 Microsoft ActiveX Template Library 3.0, when used with:  Microsoft Visual C++ 6.0 Enterprise Edition

 Microsoft Visual C++ 6.0 Professional Edition

 Microsoft Visual C++ 6.0 Standard Edition 

-

<div class="notice_section">

This article was previously published under Q190531

<div class="symptoms_section">

SYMPTOMS
When you call the delete operator or free function in an ATL project, it might cause an access violation if you are running on a multi-processor computer.

<div class="cause_section">

CAUSE
ATL provides an implementation of free in non-debug builds with _ATL_MIN_CRT defined. The delete operator is also overridden to call free. On multi-processor computers, the pointer passed in to free is used to calculate an offset to the heap's handle: void __cdecl free(void* p) { if (_Module.m_phHeaps == NULL) HeapFree(_Module.m_hHeap, 0, p); else {     HANDLE* pHeap = ((HANDLE*)p)-nOffsetBlock; HeapFree(*pHeap, 0, pHeap); } } There is no code here that checks if "p" is NULL; therefore, so HeapFree is called with an invalid handle.
 * 1) ifndef _ATL_NO_MP_HEAP
 * 1) endif
 * 1) ifndef _ATL_NO_MP_HEAP
 * 1) endif

<div class="resolution_section">

RESOLUTION
The implementation of free needs to be modified in Atlimpl.cpp. One option to resolve this problem is to just return if the pointer is NULL: void __cdecl free(void* p)  { if (p == NULL) // Add this line. return;     // Add this line. #ifndef _ATL_NO_MP_HEAP if (_Module.m_phHeaps == NULL) #endif HeapFree(_Module.m_hHeap, 0, p); #ifndef _ATL_NO_MP_HEAP else {        HANDLE* pHeap = ((HANDLE*)p)-nOffsetBlock; HeapFree(*pHeap, 0, pHeap); }  #endif } Another option to resolve this problem is to #define _ATL_NO_MP_HEAP. This prevents the problematic code from being included. However, this does turn off the optimization that ATL adds for multi-processor machines. You have only one heap regardless of the number of processors. Heap access may be less than optimal because access from multiple threads is serialized.

<div class="status_section">

STATUS
Microsoft has confirmed that this is a bug in the Microsoft products that are listed at the beginning of this article. This bug was corrected in Visual Studio 6.0 Service Pack 3. For more information about Visual Studio service packs, please see the following articles in the Microsoft Knowledge Base:

194022 INFO: Visual Studio 6.0 Service Packs, What, Where, Why

194295 HOWTO: Tell That Visual Studio 6.0 Service Packs Are Installed

<div class="moreinformation_section">

MORE INFORMATION
This bug occurs only under all of the following conditions:
 * You are running on a multi-processor computer.
 * The pointer passed to delete or free is NULL.
 * _ATL_MIN_CRT is defined (default).
 * You are building for release (_DEBUG is not defined).
 * _ATL_NO_MP_HEAP is not defined (default).

Additional query words: unhandled exception new malloc memory

Keywords: kbbug kbfix kbcrt kbvs600sp3fix KB190531

-

[mailto:TECHNET@MICROSOFT.COM Send feedback to Microsoft]

© Microsoft Corporation. All rights reserved.